Conversation
golangcibot
reviewed
Jun 2, 2019
melekes
commented
Jun 5, 2019
| certstrap request-cert -ip "::" --passphrase "" | ||
| certstrap sign "::" --CA "tendermint.com" --passphrase "" | ||
| mv out/::.crt out/::.key db/remotedb | ||
| certstrap request-cert --common-name "remotedb" -ip "127.0.0.1" --passphrase "" |
Contributor
Author
There was a problem hiding this comment.
not sure --common-name "remotedb" is correct but seems to work
melekes
commented
Jun 5, 2019
| # run the linter | ||
| # make lint | ||
|
|
||
| # setup certs |
Contributor
Author
There was a problem hiding this comment.
no need to regenerate certificates every time
Codecov Report
@@ Coverage Diff @@
## develop #3703 +/- ##
===========================================
- Coverage 63.51% 63.35% -0.16%
===========================================
Files 218 218
Lines 18239 18239
===========================================
- Hits 11585 11556 -29
- Misses 5693 5709 +16
- Partials 961 974 +13
|
ebuchman
approved these changes
Jun 22, 2019
Contributor
Contributor
Author
unclezoro
pushed a commit
to unclezoro/tendermint
that referenced
this pull request
Sep 6, 2019
* rpc/lib: write a test for TLS server Refs tendermint#3700 * do not regenerate certificates * add nolint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3700
Updated all relevant documentation in docsUpdated CHANGELOG_PENDING.md