Refactor Node; Node is a simple BaseService#369
Merged
Conversation
Current coverage is 51.33% (diff: 54.05%)@@ develop #369 diff @@
==========================================
Files 37 37
Lines 4450 4432 -18
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2216 2275 +59
+ Misses 2022 1938 -84
- Partials 212 219 +7
|
Closed
cmwaters
pushed a commit
that referenced
this pull request
Feb 11, 2022
* PBTS: second draft of protocol specification * PBTS: updates in consensus algorithm v2 * PBTS: adding/fixing links in second draft * PBTS: updated links for new algorithm specification * PBTS: changes suggested by Josef Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com> * PBTS: minor fixes and additions to spec Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com>
faddat
referenced
this pull request
in notional-labs/tendermint
Apr 3, 2023
adrianbrink
pushed a commit
to heliaxdev/tendermint
that referenced
this pull request
May 23, 2023
…dermint#377) (cherry picked from commit 280f4b9) Co-authored-by: Lasaro <lasaro@informal.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor needed to make Basecoin+Tendermint integration simple.