Conversation
Refs #3610 (comment) If we do not close, other txs will be stuck forever.
Contributor
Author
|
We should probably write more tests, but this can be done later in this particular case. |
Codecov Report
@@ Coverage Diff @@
## develop #3627 +/- ##
===========================================
+ Coverage 63.31% 63.49% +0.18%
===========================================
Files 218 218
Lines 18253 18341 +88
===========================================
+ Hits 11557 11646 +89
+ Misses 5737 5732 -5
- Partials 959 963 +4
|
Contributor
liamsi
approved these changes
May 6, 2019
libs/db/boltdb.go
Outdated
|
|
||
| // WARNING: Any concurrent writes (Set, SetSync) will block until the Iterator | ||
| // is closed. | ||
| // WARNING: Any concurrent writes (Set, SetSync) or reads will block until the |
Contributor
There was a problem hiding this comment.
Is a Delete not also a write op? I think, I'd remove (Set, SetSync) from the comment, or, add all write ops and read ops, too.
brapse
pushed a commit
to brapse/tendermint
that referenced
this pull request
Jun 5, 2019
Refs tendermint#3610 (comment) If we do not close, other txs will be stuck forever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3610 (comment)
If we do not close, other txs will be stuck forever.