Skip to content

adr renames#3622

Merged
ebuchman merged 1 commit intodevelopfrom
bucky/adr-fixes
May 5, 2019
Merged

adr renames#3622
ebuchman merged 1 commit intodevelopfrom
bucky/adr-fixes

Conversation

@ebuchman
Copy link
Contributor

@ebuchman ebuchman commented May 5, 2019

Minor fixes to match #2313

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@ebuchman ebuchman requested review from melekes and xla as code owners May 5, 2019 16:23
@codecov-io
Copy link

Codecov Report

Merging #3622 into develop will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3622      +/-   ##
===========================================
+ Coverage    63.39%   63.48%   +0.08%     
===========================================
  Files          217      217              
  Lines        18171    18171              
===========================================
+ Hits         11520    11535      +15     
+ Misses        5693     5677      -16     
- Partials       958      959       +1
Impacted Files Coverage Δ
p2p/pex/pex_reactor.go 81.6% <0%> (-1.19%) ⬇️
consensus/reactor.go 72.84% <0%> (+0.11%) ⬆️
consensus/state.go 80.56% <0%> (+0.23%) ⬆️
p2p/conn/connection.go 80.85% <0%> (+0.26%) ⬆️
blockchain/pool.go 81.9% <0%> (+1.31%) ⬆️
blockchain/reactor.go 72.42% <0%> (+1.86%) ⬆️
privval/signer_validator_endpoint.go 87.77% <0%> (+2.22%) ⬆️
privval/socket_listeners.go 89.65% <0%> (+3.44%) ⬆️
privval/signer_service_endpoint.go 89.09% <0%> (+5.45%) ⬆️

@ebuchman ebuchman merged commit 4519ef3 into develop May 5, 2019
@ebuchman ebuchman deleted the bucky/adr-fixes branch May 5, 2019 16:42
@melekes melekes mentioned this pull request May 7, 2019
36 tasks
@melekes melekes mentioned this pull request May 30, 2019
44 tasks
brapse pushed a commit to brapse/tendermint that referenced this pull request Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants