rpc: /dial_peers: only mark peers as persistent if flag is on#3620
Merged
rpc: /dial_peers: only mark peers as persistent if flag is on#3620
Conversation
also - handle errors from DialPeersAsync - remove nil addr from log msg - fix TestPEXReactorDoesNotDisconnectFromPersistentPeerInSeedMode This is a follow-up from #3593 (review)
Codecov Report
@@ Coverage Diff @@
## develop #3620 +/- ##
===========================================
+ Coverage 63.24% 63.46% +0.22%
===========================================
Files 217 217
Lines 18177 18139 -38
===========================================
+ Hits 11496 11512 +16
+ Misses 5710 5659 -51
+ Partials 971 968 -3
|
TestDialFail will trigger a reconnect
brapse
pushed a commit
to brapse/tendermint
that referenced
this pull request
Jun 5, 2019
…mint#3620) ## Description also handle errors from DialPeersAsync remove nil addr from log msg fix TestPEXReactorDoesNotDisconnectFromPersistentPeerInSeedMode This is a follow-up from tendermint#3593 (review) Fixes most of the tendermint#3617, except tendermint#3593 (comment) ## Commits * rpc: /dial_peers: only mark peers as persistent if flag is on also - handle errors from DialPeersAsync - remove nil addr from log msg - fix TestPEXReactorDoesNotDisconnectFromPersistentPeerInSeedMode This is a follow-up from tendermint#3593 (review) * remove a call to AddPersistentPeers TestDialFail will trigger a reconnect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also
This is a follow-up from
#3593 (review)
Fixes most of the #3617, except #3593 (comment)
Updated all relevant documentation in docsUpdated CHANGELOG_PENDING.md