Conversation
I am in favor of docker, but people say that running docker containers inside another container is bad. Things included in provision: - docker (latest) - jq - curl - shellcheck - golang 1.7 - glide
Val set changes
``` [ERROR] Unable to export dependencies to vendor directory: remove /home/vagrant/go/src/github.com/tendermint/tendermint/vendor/golang.org/x/sys/unix: directory not empty ```
For the tests its better to not use the timeout_commit, and to wait for all the votes, because otherwise we can end up with timing dependencies in the testing code which can lead to nondeterministic failures. That was part of the reason for this change originally.
Optional skip timeout commit
Feature: Update Vagrant setup
Current coverage is 49.92% (diff: 91.66%)@@ unstable #362 diff @@
==========================================
Files 36 36
Lines 4454 4457 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 2226 2225 -1
- Misses 2012 2016 +4
Partials 216 216
|
cmwaters
pushed a commit
that referenced
this pull request
Feb 11, 2022
faddat
referenced
this pull request
in notional-labs/tendermint
Apr 3, 2023
#345) (#362) * Allow inclusion of repository in the tag name, so ghcr and dockerub can be used, including in the same experiment * Moves UpgradeVersion to Node, so nodes can be upgraded to different versions. Uses multiversion to set UpgradeVersion. * Updates the path for the local-version image. * Do not use yoda conditions. * Use the right code coverage definitions * Revert use of . We will only do a maximum of 2 versions per run
adrianbrink
pushed a commit
to heliaxdev/tendermint
that referenced
this pull request
May 23, 2023
tendermint#345) (tendermint#362) (tendermint#363) * Allow inclusion of repository in the tag name, so ghcr and dockerub can be used, including in the same experiment * Moves UpgradeVersion to Node, so nodes can be upgraded to different versions. Uses multiversion to set UpgradeVersion. * Updates the path for the local-version image. * Do not use yoda conditions. * Use the right code coverage definitions * Revert use of . We will only do a maximum of 2 versions per run (cherry picked from commit 45a08f3) Co-authored-by: Lasaro <lasaro@informal.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.