Skip to content

abci/types: update comment#3612

Merged
liamsi merged 1 commit intodevelopfrom
3607-comment
May 2, 2019
Merged

abci/types: update comment#3612
liamsi merged 1 commit intodevelopfrom
3607-comment

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented May 2, 2019

Fixes #3607

@melekes melekes requested review from ebuchman and xla as code owners May 2, 2019 06:21
@codecov-io
Copy link

codecov-io commented May 2, 2019

Codecov Report

Merging #3612 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3612      +/-   ##
===========================================
+ Coverage    64.25%   64.26%   +<.01%     
===========================================
  Files          213      213              
  Lines        17463    17517      +54     
===========================================
+ Hits         11221    11257      +36     
- Misses        5308     5325      +17     
- Partials       934      935       +1
Impacted Files Coverage Δ
libs/clist/clist.go 66.66% <0%> (-1.52%) ⬇️
p2p/pex/pex_reactor.go 82.78% <0%> (-0.6%) ⬇️
state/errors.go 0% <0%> (ø) ⬆️
consensus/reactor.go 71.78% <0%> (+0.47%) ⬆️
blockchain/pool.go 82.23% <0%> (+1.97%) ⬆️
privval/signer_remote.go 80% <0%> (+2%) ⬆️
blockchain/reactor.go 72.89% <0%> (+2.33%) ⬆️
libs/db/remotedb/remotedb.go 40.83% <0%> (+4.93%) ⬆️
privval/signer_service_endpoint.go 85.45% <0%> (+5.45%) ⬆️

liamsi
liamsi approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @melekes 👍

@liamsi liamsi merged commit 9926ae7 into develop May 2, 2019
@melekes melekes deleted the 3607-comment branch May 2, 2019 08:37
@melekes melekes mentioned this pull request May 7, 2019
Closed
36 tasks
@melekes melekes mentioned this pull request May 30, 2019
Closed
44 tasks
brapse pushed a commit to brapse/tendermint that referenced this pull request Jun 5, 2019
@melekes @brapse
abci/types: update comment (tendermint#3612)
a2ac06e 
Fixes tendermint#3607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

@xla xla Awaiting requested review from xla

1 more reviewer

@liamsi liamsi liamsi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@melekes @codecov-io @liamsi