cli: Add option to not clear address book with unsafe reset#3606
Merged
melekes merged 2 commits intotendermint:developfrom May 1, 2019
Merged
cli: Add option to not clear address book with unsafe reset#3606melekes merged 2 commits intotendermint:developfrom
melekes merged 2 commits intotendermint:developfrom
Conversation
Contributor
Author
|
Not sure, maybe it's better to split the definitions of ResetAllCmd and ResetPrivValidatorCmd |
Codecov Report
@@ Coverage Diff @@
## develop #3606 +/- ##
==========================================
Coverage ? 64.29%
==========================================
Files ? 213
Lines ? 17449
Branches ? 0
==========================================
Hits ? 11218
Misses ? 5319
Partials ? 912
|
Contributor
|
Thanks for contributing to Tendermint 👍 |
Contributor
|
Awesome! Thanks ❤️ Even if the code is self-explanatory: Could you add a short description on what was changed and why in the PR description? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--keep-addr-bookflag tounsafe_reset_allcommand allowing not to clear address book