Skip to content

pex: various follow-ups#3605

Merged
melekes merged 3 commits intodevelopfrom
anton/small-fixes2
May 1, 2019
Merged

pex: various follow-ups#3605
melekes merged 3 commits intodevelopfrom
anton/small-fixes2

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Apr 30, 2019

No description provided.

melekes added 2 commits April 30, 2019 10:22
also improve the error msg in privval
@melekes melekes requested review from ebuchman and xla as code owners April 30, 2019 06:33
@melekes melekes changed the title p2p: small fixes p2p: various follow-ups Apr 30, 2019
@melekes melekes changed the title p2p: various follow-ups pex: various follow-ups Apr 30, 2019
@codecov-io
Copy link

codecov-io commented Apr 30, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@40dbad9). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             develop   #3605   +/-   ##
=========================================
  Coverage           ?   64.2%           
=========================================
  Files              ?     213           
  Lines              ?   17479           
  Branches           ?       0           
=========================================
  Hits               ?   11222           
  Misses             ?    5331           
  Partials           ?     926
Impacted Files Coverage Δ
p2p/pex/pex_reactor.go 83.38% <100%> (ø)

Copy link
Contributor

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Co-Authored-By: melekes <anton.kalyaev@gmail.com>
@melekes melekes merged commit 4334802 into develop May 1, 2019
@melekes melekes deleted the anton/small-fixes2 branch May 1, 2019 05:38
@melekes melekes mentioned this pull request May 7, 2019
36 tasks
@melekes melekes mentioned this pull request May 30, 2019
44 tasks
brapse pushed a commit to brapse/tendermint that referenced this pull request Jun 5, 2019
* p2p: merge switch cases

also improve the error msg in privval

* pex: refactor code plus update specification

follow-up to tendermint#3603

* Update docs/spec/reactors/pex/pex.md

Co-Authored-By: melekes <anton.kalyaev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants