Remove deprecated PanicXXX functions from codebase#3595
Merged
Conversation
As per discussion over [here](#3456 (comment)), we need to remove these `PanicXXX` functions and eliminate our dependence on them. In this PR, each and every `PanicXXX` function call is replaced with a simple `panic` call.
4 tasks
Codecov Report
@@ Coverage Diff @@
## develop #3595 +/- ##
===========================================
- Coverage 64.49% 64.35% -0.15%
===========================================
Files 213 213
Lines 17415 17448 +33
===========================================
- Hits 11232 11228 -4
- Misses 5265 5301 +36
- Partials 918 919 +1
|
melekes
approved these changes
Apr 26, 2019
brapse
pushed a commit
to brapse/tendermint
that referenced
this pull request
Jun 5, 2019
* Remove deprecated PanicXXX functions from codebase As per discussion over [here](tendermint#3456 (comment)), we need to remove these `PanicXXX` functions and eliminate our dependence on them. In this PR, each and every `PanicXXX` function call is replaced with a simple `panic` call. * add a changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per discussion over here, we need to remove these
PanicXXXfunctions and eliminate our dependence on them. In this PR, each and everyPanicXXXfunction call is replaced with a simplepaniccall.