Skip to content

CMap: slight optimization in Keys() and Values().#3567

Merged
melekes merged 1 commit intotendermint:developfrom
iphucc:patch-3
Apr 16, 2019
Merged

CMap: slight optimization in Keys() and Values().#3567
melekes merged 1 commit intotendermint:developfrom
iphucc:patch-3

Conversation

@iphucc
Copy link
Contributor

@iphucc iphucc commented Apr 16, 2019

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@iphucc iphucc requested review from ebuchman, melekes and xla as code owners April 16, 2019 07:53
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥑

@melekes
Copy link
Contributor

melekes commented Apr 16, 2019

Thanks for contributing to Tendermint 👍

@codecov-io
Copy link

Codecov Report

Merging #3567 into develop will decrease coverage by 0.14%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3567      +/-   ##
===========================================
- Coverage    64.18%   64.04%   -0.15%     
===========================================
  Files          213      213              
  Lines        17374    17348      -26     
===========================================
- Hits         11152    11111      -41     
- Misses        5292     5308      +16     
+ Partials       930      929       -1
Impacted Files Coverage Δ
libs/common/cmap.go 90.9% <100%> (ø) ⬆️
blockchain/reactor.go 71.49% <0%> (-6.29%) ⬇️
blockchain/pool.go 80.26% <0%> (-1.98%) ⬇️
privval/signer_service_endpoint.go 83.63% <0%> (-1.82%) ⬇️
consensus/reactor.go 71.54% <0%> (-0.12%) ⬇️
p2p/pex/pex_reactor.go 79.44% <0%> (ø) ⬆️
consensus/state.go 78.94% <0%> (+0.11%) ⬆️
evidence/store.go 94.54% <0%> (+1.95%) ⬆️
privval/signer_remote.go 82% <0%> (+2%) ⬆️

@melekes melekes merged commit 5b8888b into tendermint:develop Apr 16, 2019
@iphucc iphucc deleted the patch-3 branch April 16, 2019 08:34
brapse pushed a commit to brapse/tendermint that referenced this pull request Jun 5, 2019
Stumble pushed a commit to lino-network/tendermint that referenced this pull request Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants