testnet cmd: add config option#3559
Merged
melekes merged 6 commits intotendermint:developfrom Apr 23, 2019
Merged
Conversation
Contributor
|
Why don't the ability to provide the whole config ( |
Contributor
Author
|
@melekes I haven't defined the whole config due to the initial specification in the linked issue. |
Contributor
|
@gregdhill See #3160 (comment). Sorry about that. Shouldn't be too hard to refactor this PR though |
713eece to
0176a3b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3559 +/- ##
===========================================
- Coverage 64.26% 64.22% -0.05%
===========================================
Files 213 213
Lines 17447 17452 +5
===========================================
- Hits 11213 11208 -5
- Misses 5310 5323 +13
+ Partials 924 921 -3
|
melekes
reviewed
Apr 18, 2019
5afa868 to
9283cae
Compare
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
9283cae to
0b243fd
Compare
melekes
approved these changes
Apr 22, 2019
Co-Authored-By: gregdhill <gregorydhill@outlook.com>
Co-Authored-By: gregdhill <gregorydhill@outlook.com>
melekes
approved these changes
Apr 23, 2019
brapse
pushed a commit
to brapse/tendermint
that referenced
this pull request
Jun 5, 2019
Option to explicitly provide the -config in the testnet command, closing tendermint#3160.
iKapitonau
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Sep 30, 2024
…ort tendermint#3530) (tendermint#3559) Running `make all` would cause an error: `make: *** No rule to make target 'check', needed by 'all'. Stop.` The `check` target has already removed, let's delete it<hr>This is an automatic backport of pull request tendermint#3530 done by [Mergify](https://mergify.com). Co-authored-by: Halimao <1065621723@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Option to explicitly provide the
-configin thetestnetcommand, closing #3160.Updated all relevant documentation in docsWrote tests