Conversation
This reverts commit 1cf6712.
|
ref: #2279 |
looks like it |
Codecov Report
@@ Coverage Diff @@
## develop #3261 +/- ##
==========================================
Coverage ? 63.58%
==========================================
Files ? 213
Lines ? 17550
Branches ? 0
==========================================
Hits ? 11160
Misses ? 5466
Partials ? 924
|
| - nakedret | ||
| - lll | ||
| - gochecknoglobals | ||
| - govet |
There was a problem hiding this comment.
We do not pass govet? Wasn't this enabled in metalinter?
da33dd0#diff-b67911656ef5d18c4ae36cb6741b7965L252
There was a problem hiding this comment.
probably because of the older version
There was a problem hiding this comment.
Weird, I thought govet is just part of the golang distribution (the go vet command).
There was a problem hiding this comment.
Or maybe gometalinter was broken
| - gochecknoglobals | ||
| - govet | ||
| - gocritic | ||
| - gosec |
There was a problem hiding this comment.
same, wasn't this previously enabled?
da33dd0#diff-b67911656ef5d18c4ae36cb6741b7965L259
.golangci.yml
Outdated
| - gochecknoinits | ||
| - scopelint | ||
| - stylecheck | ||
| - deadcode |
There was a problem hiding this comment.
|
I think, we should merge this as is and do a follow-up PR which re-enables all previously running linters (vet, gosec, ...?) and do the changes that are necessary due to the newer versions of these linters (and decide / discuss if want to enable a few more). |
|
Yep, created #3262 |
WARN [runner/nolint] Found unknown linters in //nolint directives: gotype
Fixes tendermint#3261 This bug only affects `v0.38.x`. <!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [ ] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
This reverts commit 1cf6712.
Plus, switch from gometalinter to golangci-lint https://github.com/golangci/golangci-lint for speed and better support.