Merged
Conversation
* consensus: createProposalBlock function
* blockExecutor.CreateProposalBlock
- factored out of consensus pkg into a method on blockExec
- new private interfaces for mempool ("txNotifier") and evpool with one function each
- consensus tests still require more mempool methods
* failing test for CreateProposalBlock
* Fix bug in include evidece into block
* evidence: change maxBytes to maxSize
* MaxEvidencePerBlock
- changed to return both the max number and the max bytes
- preparation for #2590
* changelog
* fix linter
* Fix from review
Co-Authored-By: ebuchman <ethan@coinculture.info>
melekes
approved these changes
Jan 18, 2019
Codecov Report
@@ Coverage Diff @@
## master #3153 +/- ##
==========================================
- Coverage 62.91% 62.75% -0.16%
==========================================
Files 211 211
Lines 17438 17439 +1
==========================================
- Hits 10971 10944 -27
- Misses 5545 5567 +22
- Partials 922 928 +6
|
iKapitonau
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Jul 16, 2024
…endermint#3176) I updated all the old discord url to https://discord.gg/interchain or https://discord.com/invite/interchain, since the vanity link for the Cosmos discord has changed to interchain. <hr>This is an automatic backport of pull request tendermint#3153 done by [Mergify](https://mergify.com). Co-authored-by: PolyMa <151764357+polymaer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.28.1