Skip to content

Release/v0.27.3#3032

Merged
ebuchman merged 2 commits intomasterfrom
release/v0.27.3
Dec 16, 2018
Merged

Release/v0.27.3#3032
ebuchman merged 2 commits intomasterfrom
release/v0.27.3

Conversation

@ebuchman
Copy link
Contributor

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

Merge pull request #3030 from tendermint/release/v0.27.2
* crypto: revert to mainline Go crypto lib

We used to use a fork for a modified bcrypt so we could pass our own
randomness but this was largely unecessary, unused, and a burden.
So now we just use the mainline Go crypto lib.

* changelog

* fix tests

* version and changelog
@ebuchman ebuchman requested a review from melekes as a code owner December 16, 2018 19:20
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-io
Copy link

codecov-io commented Dec 16, 2018

Codecov Report

Merging #3032 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #3032      +/-   ##
=========================================
+ Coverage    62.9%   62.9%   +<.01%     
=========================================
  Files         212     212              
  Lines       17394   17363      -31     
=========================================
- Hits        10941   10922      -19     
+ Misses       5533    5524       -9     
+ Partials      920     917       -3
Impacted Files Coverage Δ
crypto/xchacha20poly1305/xchachapoly.go 92.45% <ø> (ø) ⬆️
crypto/armor/armor.go 52.38% <ø> (ø) ⬆️
crypto/xsalsa20symmetric/symmetric.go 70.37% <ø> (ø) ⬆️
crypto/secp256k1/secp256k1.go 54.09% <ø> (ø) ⬆️
crypto/hash.go 100% <ø> (ø) ⬆️
p2p/conn/secret_connection.go 73.93% <ø> (ø) ⬆️
crypto/ed25519/ed25519.go 48.43% <ø> (ø) ⬆️
libs/db/remotedb/remotedb.go 36.84% <0%> (-4.69%) ⬇️
tools/tm-bench/transacter.go 8.49% <0%> (-0.66%) ⬇️
consensus/reactor.go 65.87% <0%> (-0.24%) ⬇️
... and 2 more

@ebuchman ebuchman merged commit 0138530 into master Dec 16, 2018
@ebuchman ebuchman deleted the release/v0.27.3 branch December 16, 2018 19:30
ebuchman added a commit that referenced this pull request Dec 16, 2018
Merge pull request #3032 from tendermint/release/v0.27.3
cboh4 pushed a commit to scrtlabs/tendermint that referenced this pull request Apr 7, 2025
Closes tendermint#3029

---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [ ] ~~Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)~~
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants