Refactor updateState #2865#2929
Merged
ebuchman merged 3 commits intotendermint:developfrom Nov 28, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2929 +/- ##
==========================================
+ Coverage 62.73% 62.76% +0.02%
==========================================
Files 212 212
Lines 17410 17409 -1
==========================================
+ Hits 10922 10926 +4
+ Misses 5572 5568 -4
+ Partials 916 915 -1
|
Co-Authored-By: danil-lashin <danil-lashin@yandex.ru>
Contributor
Author
|
@melekes done, thanks! |
melekes
approved these changes
Nov 28, 2018
ebuchman
approved these changes
Nov 28, 2018
Contributor
ebuchman
left a comment
There was a problem hiding this comment.
Thanks for this!
I was hoping the abciResponses could be removed all together as an argument to updateState, since we could instead just pass in ConsensusParams. But not sure if it's worth it.
Anyways, this is fine for now. The pkg could probably continue to use some code structure improvements in the future.
iKapitonau
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Jul 16, 2024
… Anoma) (backport tendermint#2929) (tendermint#2941) --- #### PR checklist - [ ] ~~Tests written/updated~~ - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request tendermint#2929 done by [Mergify](https://mergify.com). --------- Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Andy Nogueira <me@andynogueira.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2865
Updated all relevant documentation in docsUpdated CHANGELOG_PENDING.md