Fix race condition; Refactor out txCache#290
Merged
Conversation
Current coverage is 37.72% (diff: 50.00%)@@ develop #290 diff @@
==========================================
Files 30 30
Lines 3723 3743 +20
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1407 1412 +5
- Misses 2170 2185 +15
Partials 146 146
|
Contributor
|
@jaekwon I've retested this to the best of my knowledge. It looks good for me. Didn't stop any nodes as opposed to current master, where I sometimes got a hold after 20 seconds and usually after 1 minute. Had some testruns with my debug scenario and our current prototype as well against |
Contributor
|
LGTM. Though I'd like to add some unit tests so we can catch the previous bug and show this fixes it. Hopefully today/tomorrow. |
4c1dcad to
a07063f
Compare
Closed
troian
pushed a commit
to akash-network/tendermint
that referenced
this pull request
Mar 11, 2023
…#290) * Updated method for running 200 node test * fix & extend * one more... * update hashes * Adapting text of latency extraction method * Script adjustments * Small precision * Update docs/qa/method.md Thanks! Co-authored-by: Lasaro <lasaro@informal.systems> * Update docs/qa/method.md Co-authored-by: Lasaro <lasaro@informal.systems> * Update docs/qa/method.md Co-authored-by: Lasaro <lasaro@informal.systems> --------- Co-authored-by: Lasaro <lasaro@informal.systems> (cherry picked from commit d82bc77) Co-authored-by: Sergio Mena <sergio@informal.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference:
@srmo, can you check that this works?