Skip to content

2871 remove proposalHeartbeat infrastructure#2874

Merged
ebuchman merged 4 commits intotendermint:developfrom
srmo:2871-remove-proposal-hearbeat
Nov 28, 2018
Merged

2871 remove proposalHeartbeat infrastructure#2874
ebuchman merged 4 commits intotendermint:developfrom
srmo:2871-remove-proposal-hearbeat

Conversation

@srmo
Copy link
Contributor

@srmo srmo commented Nov 17, 2018 •
edited
Loading

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Updated CHANGELOG_PENDING.md

@srmo
Copy link
Contributor Author

srmo commented Nov 17, 2018

Circle fails with

--- FAIL: TestPEXReactorUsesSeedsIfNeeded (0.00s)
panic: listen tcp 127.0.0.1:32200: bind: address already in use [recovered]
	panic: listen tcp 127.0.0.1:32200: bind: address already in use

goroutine 492 [running]:
testing.tRunner.func1(0xc42025af00)
	/usr/local/go/src/testing/testing.go:742 +0x567
panic(0xb2e820, 0xc420634050)
	/usr/local/go/src/runtime/panic.go:502 +0x24a
github.com/tendermint/tendermint/p2p.MakeSwitch(0xc420262000, 0x0, 0xbb196a, 0x9, 0xbb25c5, 0xb, 0xc4200a9e70, 0x0, 0x0, 0x0, ...)
	/go/src/github.com/tendermint/tendermint/p2p/test_util.go:182 +0xdb4
github.com/tendermint/tendermint/p2p/pex.testCreateSeed(0xc4203be080, 0x19, 0x0, 0xc420099f18, 0x0, 0x0, 0xc420099f18, 0x0, 0x0, 0x404b30)
	/go/src/github.com/tendermint/tendermint/p2p/pex/pex_reactor_test.go:487 +0x196
github.com/tendermint/tendermint/p2p/pex.TestPEXReactorUsesSeedsIfNeeded(0xc42025af00)
	/go/src/github.com/tendermint/tendermint/p2p/pex/pex_reactor_test.go:251 +0x136
testing.tRunner(0xc42025af00, 0xcf5230)
	/usr/local/go/src/testing/testing.go:777 +0x16e
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:824 +0x565
FAIL	github.com/tendermint/tendermint/p2p/pex	0.706s
Exited with code 1
``` - no idea how to retrigger tests. Local build is good.

@srmo srmo mentioned this pull request Nov 17, 2018
Closed
4 tasks
@codecov-io
Copy link

codecov-io commented Nov 17, 2018

Codecov Report

Merging #2874 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2874      +/-   ##
===========================================
- Coverage     62.1%   62.08%   -0.02%     
===========================================
  Files          212      212              
  Lines        17288    17213      -75     
===========================================
- Hits         10736    10686      -50     
+ Misses        5647     5624      -23     
+ Partials       905      903       -2
Impacted Files Coverage Δ
consensus/state.go 79.64% <ø> (-0.25%) ⬇️
privval/priv_validator.go 74.4% <ø> (+3.38%) ⬆️
privval/remote_signer.go 82.75% <ø> (-0.1%) ⬇️
consensus/reactor.go 65.87% <ø> (+0.4%) ⬆️
libs/events/events.go 93.2% <0%> (-4.86%) ⬇️
mempool/wire.go 100% <0%> (ø) ⬆️
libs/db/remotedb/grpcdb/client.go 0% <0%> (ø) ⬆️
libs/clist/clist.go 68.18% <0%> (+1.51%) ⬆️
... and 1 more

melekes
melekes approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

liamsi added a commit to tendermint/tmkms that referenced this pull request Nov 19, 2018
@liamsi
Remove heartbeat to catch up with:
30d0e70 
tendermint/tendermint#2874
@liamsi liamsi mentioned this pull request Nov 19, 2018
Merged
liamsi
liamsi approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srmo!

@melekes melekes added the T:breaking Type: Breaking Change label Nov 27, 2018
ebuchman
ebuchman approved these changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@ebuchman ebuchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most beautiful PR in all the land!

@ebuchman ebuchman merged commit e291fbb into tendermint:develop Nov 28, 2018
@srmo srmo deleted the 2871-remove-proposal-hearbeat branch November 28, 2018 17:21
tarcieri pushed a commit to cometbft/tendermint-rs that referenced this pull request Aug 1, 2019
@liamsi
Remove heartbeat to catch up with:
52bd7d0 
tendermint/tendermint#2874
lklimek pushed a commit to lklimek/tenderdash-abci-rs that referenced this pull request Feb 28, 2023
@liamsi
Remove heartbeat to catch up with:
ee55345 
tendermint/tendermint#2874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xla xla Awaiting requested review from xla

@zramsay zramsay Awaiting requested review from zramsay

3 more reviewers

@melekes melekes melekes approved these changes

@ebuchman ebuchman ebuchman approved these changes

@liamsi liamsi liamsi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T:breaking Type: Breaking Change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@srmo @codecov-io @melekes @ebuchman @liamsi