Skip to content

Update to amino 0.14.0#2710

Merged
ebuchman merged 3 commits intodevelopfrom
amino0.14.0
Oct 29, 2018
Merged

Update to amino 0.14.0#2710
ebuchman merged 3 commits intodevelopfrom
amino0.14.0

Conversation

@liamsi
Copy link
Contributor

@liamsi liamsi commented Oct 26, 2018 •
edited
Loading

resolves #2682

depends on: tendermint/go-amino#240

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@codecov-io
Copy link

codecov-io commented Oct 26, 2018 •
edited
Loading

Codecov Report

Merging #2710 into develop will decrease coverage by 0.1%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2710      +/-   ##
===========================================
- Coverage    61.72%   61.62%   -0.11%     
===========================================
  Files          207      207              
  Lines        16942    16942              
===========================================
- Hits         10458    10440      -18     
- Misses        5622     5639      +17     
- Partials       862      863       +1
Impacted Files Coverage Δ
consensus/state.go 75.93% <0%> (-3.06%) ⬇️
consensus/reactor.go 72.77% <0%> (+0.77%) ⬆️
privval/tcp_server.go 81.42% <0%> (+2.85%) ⬆️

melekes
melekes approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍇

@liamsi liamsi changed the title WIP: update to amino 0.14.0 Update to amino 0.14.0 Oct 26, 2018
@liamsi liamsi mentioned this pull request Oct 26, 2018
Closed
@ebuchman
Copy link
Contributor

ebuchman commented Oct 29, 2018

Oh damn, seeing lots of seemingly serialization related errors in the test_p2p logs:

2018-10-26T16:14:43+00:00 172.17.0.1 local_testnet_1[1296]: E[10-26|16:14:43.212] Connection failed @ recvRoutine (reading byte) module=p2p peer=0x9278d0 conn=MConn{172.57.0.104:26656} err="unmarshal to conn.Packet failed after 4 bytes (unrecognized prefix bytes B05B7258): B05B72589B957B7A25DB996B381C3D42C0008F2DD76CEEAE62FD8F62E69E2D39515F66DEFC2851764BA467B2A90B104DC618389D3F887903F8497A861CABFE13013FAC88930B6C25E7B1AB953135464D80BE731218080112141C78D31EDB97FB3223DE5E8E979488A981E5507A42402B56B084F4A368F170FF1BA15D42D86807D2A79D4503C6BF125345AE41CCE5D2B56D8FC53093EFB0292A9D66EDC25BC8168343B74F6C46B505F3F9E6DB35B10D"

and

2018-10-26T16:12:03+00:00 172.17.0.1 local_testnet_3[1296]: E[10-26|16:12:03.823] Error attempting to add vote                 module=consensus err="Failed to verify vote with ChainID chain-9ujDWI and PubKey PubKeyEd25519{6DC534465323126587D2A2A93B59D689B717073B1DE968A25A6EF13D595318AD}: Invalid signature"

and

2018-10-26T16:14:43+00:00 172.17.0.1 local_testnet_1[1296]: E[10-26|16:14:43.440] Error on ApplyBlock. Did the application crash? Please restart tendermint module=consensus err="Invalid commit -- invalid signature: Vote{0:5D61EE46CCE9 8/00/2(Precommit) 51BB268B4C2D ECD0D4031611 @ 2018-10-26T16:14:41.674216938Z}"

@ebuchman
Copy link
Contributor

ebuchman commented Oct 29, 2018

Looks like they may have been due to stale data. Thanks Ismail!

@ebuchman ebuchman merged commit b6d5b8b into develop Oct 29, 2018
@ebuchman ebuchman deleted the amino0.14.0 branch October 29, 2018 13:16
@liamsi liamsi mentioned this pull request Oct 29, 2018
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

@xla xla Awaiting requested review from xla

1 more reviewer

@melekes melekes melekes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liamsi @codecov-io @ebuchman @melekes