Skip to content

types: discrepancy between amino and proto3 #2682

@ebuchman

Description

@ebuchman

The amino encoding of the types.Header doesn't match the proto3 encoding of the abci.Header. See the failing test in #2681.

Even when we use amino v0.13, it still doesn't match. For the empty time, we get:

expected: []byte{0x22, 0xb, 0x8, 0x80, 0x92, 0xb8, 0xc3, 0x98, 0xfe, 0xff, 0xff, 0xff, 0x1}
actual  : []byte{0xa, 0x0, 0x22, 0xb, 0x8, 0x80, 0x92, 0xb8, 0xc3, 0x98, 0xfe, 0xff, 0xff, 0xff, 0x1, 0x3a, 0x2, 0x12, 0x0}

where the former is Amino encoding, the later is proto3 encoding. Note the proto3 encoding prepends and appends some bytes to the Amino encoding.

This should probably block v0.26

Metadata

Metadata

Assignees

No one assigned

    Labels

    C:libsComponent: LibraryT:bugType Bug (Confirmed)T:encodingType: Amino, ProtoBuf

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions