Conversation
8a71360 to
2fc5d86
Compare
liamsi
commented
Oct 22, 2018
blockchain/store.go
Outdated
| buf = append(buf, part.Bytes...) | ||
| } | ||
| err := cdc.UnmarshalBinary(buf, block) | ||
| err := cdc.UnmarshalBinaryLengthPrefixedBinary(buf, block) |
Contributor
Author
There was a problem hiding this comment.
Oh no, this should actually be named: UnmarshalBinaryLengthPrefixed instead 🙈 Not sure how me and two reviewers didn't see that. I'll delete the release 0.13.0 for now and add a commit to master that fixes that (and tag this again).
Contributor
Author
There was a problem hiding this comment.
Contributor
|
Should we merge #2687 first? |
Contributor
Author
|
Yes, we should. Otherwise we'd probably have to redo the changes from #2687 here, too. |
5 tasks
Contributor
Author
|
Should be ready for review if circleci passes. |
ebuchman
approved these changes
Oct 25, 2018
Contributor
ebuchman
left a comment
There was a problem hiding this comment.
Cool, thanks.
Very clear now that we length prefix everything ;). We should open a separate issue to consider if maybe we shouldn't actually do that everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2687
related: tendermint/go-amino#222
related: #2687
related: tendermint/go-amino#233