Conversation
4 tasks
Contributor
Author
|
@liamsi should we cut a rc1 of amino or make the full release so we can update the MarshalBinary -> MarshalBinaryLenPrefixed as well? |
melekes
approved these changes
Oct 22, 2018
Contributor
|
Let's do a 0.13.0 release that includes the MarshalBinary -> MarshalBinaryLenPrefixed, too. |
Codecov Report
@@ Coverage Diff @@
## develop #2687 +/- ##
===========================================
- Coverage 61.56% 61.53% -0.04%
===========================================
Files 207 207
Lines 16939 16931 -8
===========================================
- Hits 10429 10418 -11
Misses 5647 5647
- Partials 863 866 +3
|
5 tasks
ebuchman
commented
Oct 23, 2018
| block.LastResultsHash = state.LastResultsHash | ||
|
|
||
| // NOTE: we can't use the state.Validators because we don't | ||
| // IncrementAccum for rounds there. |
Contributor
Author
There was a problem hiding this comment.
We should add this note about the IncrementAccum to the godoc for the method
liamsi
reviewed
Oct 23, 2018
| } | ||
| for i, tc := range tests { | ||
| got, err := cdc.MarshalBinary(tc.canonicalVote) | ||
| got, err := cdc.MarshalBinaryBare(tc.canonicalVote) |
Contributor
There was a problem hiding this comment.
The SignBytes still use MarshalBinary (now MarshalBinaryLengthPrefixed). It's a bit weird to change this in the tests only. Also, I actually use the length in the kms, too. Not blocking a release though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to Amino v0.13 which updates the way time is encoded.
Also fixes a bug where we weren't sending Version or NextValidatorsHash in the header to the ABCI app
Replaces #2681, for now