Merged
Conversation
Contributor
ebuchman
commented
Aug 27, 2016
- refactor some of the bash tests
- add test for fast sync
- fix fast sync
Contributor
Author
|
In future, we should use one call to ApplyBlock instead of the ExecBlock, Commit, Save sequence we have here. See #265 |
| break SYNC_LOOP | ||
| } else { | ||
| bcR.pool.PopRequest() | ||
| // TODO: use ApplyBlock instead of Exec/Commit/SetAppHash/Save |
Contributor
Author
There was a problem hiding this comment.
see handshake branch. it basically puts the ExecBlock, Commit, and setting of state root in one function
Contributor
|
LGTM |
faddat
pushed a commit
to faddat/tendermint
that referenced
this pull request
Nov 23, 2022
faddat
referenced
this pull request
in notional-labs/tendermint
Apr 3, 2023
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3.3.0 to 4.0.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3.3.0...v4.0.0) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.