Skip to content

adr-016: update int64->uint64; add version to ConsensusParams#2667

Merged
ebuchman merged 1 commit intodevelopfrom
bucky/adr-016-update
Oct 18, 2018
Merged

adr-016: update int64->uint64; add version to ConsensusParams#2667
ebuchman merged 1 commit intodevelopfrom
bucky/adr-016-update

Conversation

@ebuchman
Copy link
Contributor

Ref #2468

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@ebuchman ebuchman requested a review from zramsay as a code owner October 18, 2018 21:13
@codecov-io
Copy link

Codecov Report

Merging #2667 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2667      +/-   ##
===========================================
+ Coverage    61.61%   61.63%   +0.02%     
===========================================
  Files          207      207              
  Lines        16928    16916      -12     
===========================================
- Hits         10430    10426       -4     
+ Misses        5628     5622       -6     
+ Partials       870      868       -2
Impacted Files Coverage Δ
privval/tcp_server.go 78.57% <0%> (-2.86%) ⬇️
types/time/time.go 100% <0%> (ø) ⬆️
consensus/state.go 76.17% <0%> (+0.23%) ⬆️
p2p/pex/addrbook.go 70.07% <0%> (+0.48%) ⬆️
p2p/pex/pex_reactor.go 75% <0%> (+1%) ⬆️
privval/ipc_server.go 69.81% <0%> (+5.66%) ⬆️

Copy link
Contributor

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ebuchman ebuchman merged commit c3384e8 into develop Oct 18, 2018
@ebuchman ebuchman deleted the bucky/adr-016-update branch October 18, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants