Skip to content

types: remove Version from CanonicalXxx#2666

Merged
ebuchman merged 1 commit intodevelopfrom
bucky/versions-canonical-sign-bytes
Oct 18, 2018
Merged

types: remove Version from CanonicalXxx#2666
ebuchman merged 1 commit intodevelopfrom
bucky/versions-canonical-sign-bytes

Conversation

@ebuchman
Copy link
Contributor

@ebuchman ebuchman commented Oct 18, 2018

Ref #2665 and #2468

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@codecov-io
Copy link

Codecov Report

Merging #2666 into develop will increase coverage by 0.14%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2666      +/-   ##
===========================================
+ Coverage    61.61%   61.76%   +0.14%     
===========================================
  Files          207      207              
  Lines        16928    16928              
===========================================
+ Hits         10430    10455      +25     
+ Misses        5628     5607      -21     
+ Partials       870      866       -4
Impacted Files Coverage Δ
consensus/state.go 77.11% <0%> (+1.17%) ⬆️
consensus/reactor.go 72.12% <0%> (+1.54%) ⬆️
privval/ipc_server.go 69.81% <0%> (+5.66%) ⬆️

Copy link
Contributor

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ebuchman ebuchman merged commit e798766 into develop Oct 18, 2018
@ebuchman ebuchman deleted the bucky/versions-canonical-sign-bytes branch October 18, 2018 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants