ADR-016: Add protocol Version to NodeInfo#2654
Merged
Conversation
This was referenced Oct 17, 2018
Codecov Report
@@ Coverage Diff @@
## develop #2654 +/- ##
==========================================
Coverage ? 61.55%
==========================================
Files ? 207
Lines ? 16896
Branches ? 0
==========================================
Hits ? 10400
Misses ? 5630
Partials ? 866
|
liamsi
approved these changes
Oct 18, 2018
| default: | ||
| return fmt.Errorf("info.Other.TxIndex should be either 'on' or 'off', got '%v'", txIndex) | ||
| } | ||
| // XXX: Should we be more strict about address formats? |
Contributor
There was a problem hiding this comment.
Are they always IP4 addresses?
Contributor
Author
There was a problem hiding this comment.
No actually, in theory they could be IPv6. We don't actually do anything with this RPCAddress though, just display it over RPC, so it doesn't matter too much here ...
melekes
reviewed
Oct 18, 2018
| switch txIndex { | ||
| case "", "on", "off": | ||
| default: | ||
| return fmt.Errorf("info.Other.TxIndex should be either 'on' or 'off', got '%v'", txIndex) |
Contributor
There was a problem hiding this comment.
'on' or 'off' or empty string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More from #2468