Conversation
281d7a8 to
62eafed
Compare
Why: - native type provides better guarantees than ", in ms" comment (harder to shoot yourself in the leg) - flexibility: you can change units
62eafed to
cb56692
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2485 +/- ##
===========================================
- Coverage 61.36% 61.32% -0.05%
===========================================
Files 197 197
Lines 16449 16496 +47
===========================================
+ Hits 10094 10116 +22
- Misses 5517 5522 +5
- Partials 838 858 +20
|
zramsay
approved these changes
Sep 25, 2018
ebuchman
reviewed
Sep 28, 2018
|
|
||
| * Go API | ||
| - [node] Remove node.RunForever | ||
| - [config] \#2232 timeouts as time.Duration, not ints |
Contributor
There was a problem hiding this comment.
Also a breaking change to the CLI/RPC/Config section since this now means the timeout params in the config.toml are strings like "100ms" or "3s"
iKapitonau
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Jul 10, 2024
…endermint#2485) This is an automatic backport of pull request tendermint#2483 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Sergio Mena <sergio@informal.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT SQUASH BEFORE MERGING
Updated all relevant documentation in docs