Skip to content

add missing changelog entry and comment#2451

Merged
xla merged 1 commit intodevelopfrom
anton/2411-follow-up
Sep 20, 2018
Merged

add missing changelog entry and comment#2451
xla merged 1 commit intodevelopfrom
anton/2411-follow-up

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Sep 20, 2018

#2411 follow-up

@codecov-io
Copy link

Codecov Report

Merging #2451 into develop will increase coverage by 0.18%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #2451      +/-   ##
===========================================
+ Coverage    61.43%   61.62%   +0.18%     
===========================================
  Files          197      197              
  Lines        16348    16308      -40     
===========================================
+ Hits         10043    10049       +6     
+ Misses        5469     5424      -45     
+ Partials       836      835       -1
Impacted Files Coverage Δ
libs/db/db.go 38.88% <0%> (-4.87%) ⬇️
libs/db/remotedb/grpcdb/server.go 0% <0%> (ø) ⬆️
consensus/reactor.go 73.55% <0%> (+0.53%) ⬆️
libs/autofile/autofile.go 77.46% <0%> (+2.81%) ⬆️

Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :octocat: :shipit: 🍡

@xla xla merged commit bd95117 into develop Sep 20, 2018
@xla xla deleted the anton/2411-follow-up branch September 20, 2018 09:14
iKapitonau pushed a commit to scrtlabs/tendermint that referenced this pull request Jul 10, 2024
…t#2434) (tendermint#2451)

This is an automatic backport of pull request tendermint#2434 done by
[Mergify](https://mergify.com).
Cherry-pick of 8bf81d423ff80a36fd13b9df07e6e9be6f497927 has failed:
```
On branch mergify/bp/v0.38.x/pr-2434
Your branch is up to date with 'origin/v0.38.x'.

You are currently cherry-picking commit 8bf81d423.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .changelog/unreleased/improvements/2434-jsonrpc-websocket-basic-auth.md

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rpc/jsonrpc/client/ws_client.go

```


To fix up this pull request, you can check it out locally. See
documentation:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

---------

Co-authored-by: Matt Ketmo <matthieu@moquet.net>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants