Merged
Conversation
Follow-up on #2411
Codecov Report
@@ Coverage Diff @@
## develop #2451 +/- ##
===========================================
+ Coverage 61.43% 61.62% +0.18%
===========================================
Files 197 197
Lines 16348 16308 -40
===========================================
+ Hits 10043 10049 +6
+ Misses 5469 5424 -45
+ Partials 836 835 -1
|
iKapitonau
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Jul 10, 2024
…t#2434) (tendermint#2451) This is an automatic backport of pull request tendermint#2434 done by [Mergify](https://mergify.com). Cherry-pick of 8bf81d423ff80a36fd13b9df07e6e9be6f497927 has failed: ``` On branch mergify/bp/v0.38.x/pr-2434 Your branch is up to date with 'origin/v0.38.x'. You are currently cherry-picking commit 8bf81d423. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Changes to be committed: new file: .changelog/unreleased/improvements/2434-jsonrpc-websocket-basic-auth.md Unmerged paths: (use "git add <file>..." to mark resolution) both modified: rpc/jsonrpc/client/ws_client.go ``` To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> --------- Co-authored-by: Matt Ketmo <matthieu@moquet.net> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2411 follow-up