Conversation
Handshaker was removed from proxy package so it can be called independently of starting the abci app connections and can return a result to the caller.
Codecov Report
@@ Coverage Diff @@
## develop #2437 +/- ##
===========================================
- Coverage 61.28% 61.26% -0.02%
===========================================
Files 198 198
Lines 16383 16390 +7
===========================================
+ Hits 10040 10042 +2
- Misses 5508 5511 +3
- Partials 835 837 +2
|
Codecov Report
@@ Coverage Diff @@
## develop #2437 +/- ##
===========================================
+ Coverage 61.28% 61.43% +0.14%
===========================================
Files 198 198
Lines 16383 16387 +4
===========================================
+ Hits 10040 10067 +27
+ Misses 5508 5492 -16
+ Partials 835 828 -7
|
melekes
approved these changes
Sep 19, 2018
| // run the whole chain against this client to build up the tendermint state | ||
| clientCreator := proxy.NewLocalClientCreator(kvstore.NewPersistentKVStoreApplication(path.Join(config.DBDir(), "1"))) | ||
| proxyApp := proxy.NewAppConns(clientCreator, nil) // sm.NewHandshaker(config, state, store, ReplayLastBlock)) | ||
| proxyApp := proxy.NewAppConns(clientCreator) // sm.NewHandshaker(config, state, store, ReplayLastBlock)) |
Contributor
There was a problem hiding this comment.
comment should either be removed OR moved to where handshaker is being created
xla
approved these changes
Sep 19, 2018
Contributor
xla
left a comment
There was a problem hiding this comment.
👍 
🍡
I for one welcome our new liberated handshaking overlords.
|
|
||
| handshaker := NewHandshaker(stateDB, state, blockStore, gdoc) | ||
| err = handshaker.Handshake(proxyApp) | ||
| if err != nil { |
Contributor
There was a problem hiding this comment.
Can be collapsed into: if err := handhsaker.Handshake(proxyApp); err != nil {
iKapitonau
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Jul 10, 2024
) (tendermint#2437) This is an automatic backport of pull request tendermint#2414 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: DragonKid <idragonkid@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handshaker was removed from proxy package so it can be called
independently of starting the abci app connections and can return a
result to the caller.
Ref #2436