update UPGRADING.md and minor docs fixes#2349
Merged
Conversation
Contributor
Author
|
Merging to get this on develop for website staging. Then ready to make a PR to master for final release |
Merged
melekes
reviewed
Sep 7, 2018
|
|
||
| ### Validator Set Updates | ||
|
|
||
| Validator set updates returned in ResponseEndBlock for height `H` used to take |
Contributor
There was a problem hiding this comment.
Don't think we should duplicate changelog entries here (except when they lead to clear actions like change this or do that)
Contributor
Author
There was a problem hiding this comment.
Ok - wasn't sure how to think about this. The point is that for val sets they do have to change the way they track them in the app and I wanted to better indicate that. I'll add more text.
iKapitonau
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Jul 10, 2024
to unblock development <!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [ ] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note commits 114c405 and 5106af4 were pushed straight to develop.
This is just more follow up on the docs/changelog/upgrading.