Skip to content

Several minor docs & spec cleanup#2330

Merged
melekes merged 5 commits intodevelopfrom
zach/docs-improvements
Sep 5, 2018
Merged

Several minor docs & spec cleanup#2330
melekes merged 5 commits intodevelopfrom
zach/docs-improvements

Conversation

@zramsay
Copy link
Contributor

@zramsay zramsay commented Sep 4, 2018

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

config/config.go Outdated
AddrBook string `mapstructure:"addr_book_file"`

// Set true for strict address routability rules
// Set false for local networks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for local or private networks

config/toml.go Outdated
addr_book_file = "{{ js .P2P.AddrBook }}"

# Set true for strict address routability rules
# Set false for local networks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

addr_book_file = "addrbook.json"

# Set true for strict address routability rules
# Set false for local networks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@codecov-io
Copy link

Codecov Report

Merging #2330 into develop will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2330      +/-   ##
===========================================
+ Coverage    60.96%   61.05%   +0.08%     
===========================================
  Files          197      197              
  Lines        16282    16283       +1     
===========================================
+ Hits          9927     9942      +15     
+ Misses        5490     5479      -11     
+ Partials       865      862       -3
Impacted Files Coverage Δ
config/config.go 82.58% <ø> (ø) ⬆️
config/toml.go 53.19% <ø> (ø) ⬆️
evidence/wire.go 100% <0%> (ø) ⬆️
p2p/peer.go 57.95% <0%> (ø) ⬆️
consensus/reactor.go 73.82% <0%> (+0.8%) ⬆️
consensus/state.go 78.35% <0%> (+0.95%) ⬆️

@melekes melekes merged commit 92185c0 into develop Sep 5, 2018
@melekes melekes deleted the zach/docs-improvements branch September 5, 2018 06:30
iKapitonau pushed a commit to scrtlabs/tendermint that referenced this pull request Jul 10, 2024
…ermint#2342)

This is an automatic backport of pull request tendermint#2330 done by
[Mergify](https://mergify.com).
Cherry-pick of a6cc64d0712f037faa48751dd83ed070d5339763 has failed:
```
On branch mergify/bp/v0.38.x/pr-2330
Your branch is up to date with 'origin/v0.38.x'.

You are currently cherry-picking commit a6cc64d07.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/introduction/README.md

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   docs/core/running-in-production.md
	both modified:   docs/core/subscription.md

```


To fix up this pull request, you can check it out locally. See
documentation:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

---------

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants