Merged
Conversation
Contributor
zramsay
commented
Sep 4, 2018
- addresses a few points in docs: suggestions/issues from review #2143
- removes most TODO's from spec for better readability. documented in TODO notes from spec #1152 docs/spec: update blockchain.md #1749 spec: document Evidence #2329
- Updated all relevant documentation in docs
- Updated all code comments where relevant
- Wrote tests
- Updated CHANGELOG_PENDING.md
melekes
approved these changes
Sep 5, 2018
config/config.go
Outdated
| AddrBook string `mapstructure:"addr_book_file"` | ||
|
|
||
| // Set true for strict address routability rules | ||
| // Set false for local networks |
Contributor
There was a problem hiding this comment.
for local or private networks
config/toml.go
Outdated
| addr_book_file = "{{ js .P2P.AddrBook }}" | ||
|
|
||
| # Set true for strict address routability rules | ||
| # Set false for local networks |
| addr_book_file = "addrbook.json" | ||
|
|
||
| # Set true for strict address routability rules | ||
| # Set false for local networks |
Codecov Report
@@ Coverage Diff @@
## develop #2330 +/- ##
===========================================
+ Coverage 60.96% 61.05% +0.08%
===========================================
Files 197 197
Lines 16282 16283 +1
===========================================
+ Hits 9927 9942 +15
+ Misses 5490 5479 -11
+ Partials 865 862 -3
|
iKapitonau
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Jul 10, 2024
…ermint#2342) This is an automatic backport of pull request tendermint#2330 done by [Mergify](https://mergify.com). Cherry-pick of a6cc64d0712f037faa48751dd83ed070d5339763 has failed: ``` On branch mergify/bp/v0.38.x/pr-2330 Your branch is up to date with 'origin/v0.38.x'. You are currently cherry-picking commit a6cc64d07. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Changes to be committed: modified: docs/introduction/README.md Unmerged paths: (use "git add <file>..." to mark resolution) both modified: docs/core/running-in-production.md both modified: docs/core/subscription.md ``` To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.