Skip to content

expect all tags to be strings#1498

Merged
melekes merged 2 commits intodevelopfrom
1369-subscribing-issue
May 28, 2018
Merged

expect all tags to be strings#1498
melekes merged 2 commits intodevelopfrom
1369-subscribing-issue

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Apr 26, 2018

Refs #1369

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@melekes melekes requested a review from ebuchman as a code owner April 26, 2018 08:16
@melekes
Copy link
Contributor Author

melekes commented Apr 28, 2018

tendermint/tmlibs#204

xla
xla approved these changes Apr 30, 2018
View reviewed changes
Copy link
Contributor

@xla xla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the test. Is the conflict in the Gopkg.lock temporary until the depending PR in tmlibs is through?

👍 :octocat: :shipit:

@codecov-io
Copy link

codecov-io commented Apr 30, 2018

Codecov Report

Merging #1498 into develop will decrease coverage by 0.3%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1498      +/-   ##
===========================================
- Coverage    63.87%   63.56%   -0.31%     
===========================================
  Files          102      102              
  Lines         9455     9456       +1     
===========================================
- Hits          6039     6011      -28     
- Misses        2854     2877      +23     
- Partials       562      568       +6
Impacted Files Coverage Δ
consensus/reactor.go 72.46% <0%> (-1.59%) ⬇️
consensus/state.go 76.25% <0%> (-1.36%) ⬇️
rpc/client/httpclient.go 68.36% <0%> (-1.03%) ⬇️
evidence/store.go 92% <0%> (-0.41%) ⬇️
blockchain/pool.go 68.05% <0%> (ø) ⬆️
consensus/replay_file.go 0% <0%> (ø) ⬆️

@melekes
Copy link
Contributor Author

melekes commented May 17, 2018

Wait until #1574 get merged and port changes from tendermint/tmlibs#204

@melekes melekes force-pushed the 1369-subscribing-issue branch from 9a8240f to d931d35 Compare May 28, 2018 08:58
@melekes melekes force-pushed the 1369-subscribing-issue branch from d931d35 to 9d071c9 Compare May 28, 2018 08:59
@melekes melekes merged commit 6004587 into develop May 28, 2018
@melekes melekes deleted the 1369-subscribing-issue branch May 28, 2018 10:37
@ethanfrey ethanfrey mentioned this pull request Apr 28, 2021
Closed
firelizzard18 pushed a commit to AccumulateNetwork/tendermint that referenced this pull request Feb 1, 2024
@dependabot
build(deps): Bump google.golang.org/grpc from 1.58.2 to 1.58.3 (tende…
a796bd9 
…rmint#1498)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.58.2 to 1.58.3.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.58.2...v1.58.3)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

1 more reviewer

@xla xla xla approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@melekes @codecov-io @xla