Merged
Conversation
Contributor
greg-szabo
commented
Apr 11, 2018
- Updated all relevant documentation in docs
- Updated all code comments where relevant
- Wrote tests
- Updated CHANGELOG.md
…ctored to use the tendermint testnet command
greg-szabo
commented
Apr 11, 2018
Makefile
Outdated
| # Run a 4-node testnet locally | ||
| docker-start: | ||
| # @echo "Wait until 'Attaching to mach0, mach1, mach2, mach3' message appears" | ||
| @if ! [ -f build/mach0/config/genesis.json ]; then docker run --rm -e LOG="stdout" -v `pwd`/build:/tendermint tendermint/localnode testnet --dir . --n 4 ; fi |
Contributor
Author
There was a problem hiding this comment.
format was changed
greg-szabo
commented
Apr 11, 2018
docker-compose/Makefile
Outdated
| @@ -0,0 +1,13 @@ | |||
| # Makefile for the "localnode" docker image. | |||
|
|
|||
| localnode: | |||
greg-szabo
commented
Apr 11, 2018
docker-compose/localnode/wrapper.sh
Outdated
| exit 1 | ||
| fi | ||
|
|
||
| ## |
greg-szabo
commented
Apr 11, 2018
docker-compose/localnode/wrapper.sh
Outdated
| ## Assert linux binary | ||
| ## | ||
| if ! [ -f "${BINARY}" ]; then | ||
| echo "The binary `basename ${BINARY}` cannot be found. Please add the binary to the shared folder. E.g.: -e BINARY=tendermint_my_test_version" |
Contributor
Author
There was a problem hiding this comment.
. E.g.: shared folder or use env variable to set binary
melekes
reviewed
Apr 11, 2018
Makefile
Outdated
| gometalinter.v2 --vendor --deadline=600s --enable-all --disable=lll ./... | ||
|
|
||
| ########################################################### | ||
| ### Local testnet using docker - for developer use only! |
Contributor
There was a problem hiding this comment.
"for developer use only!"
let's remove that too. people should understand what they are doing
melekes
reviewed
Apr 11, 2018
Makefile
Outdated
|
|
||
| # Run a 4-node testnet locally | ||
| docker-start: | ||
| # @echo "Wait until 'Attaching to mach0, mach1, mach2, mach3' message appears" |
melekes
reviewed
Apr 11, 2018
docker-compose/Makefile
Outdated
| localnode: | ||
| docker build --tag tendermint/localnode localnode | ||
|
|
||
| squash: |
melekes
reviewed
Apr 11, 2018
docker-compose/README.rst
Outdated
| make build-linux | ||
|
|
||
| #Create configuration | ||
| docker run -e LOG="stdout" -v `pwd`/build:/tendermint tendermint/localnode testnet --dir . --n 1 |
Contributor
There was a problem hiding this comment.
needs to be updated as well
Codecov Report
@@ Coverage Diff @@
## develop #1450 +/- ##
==========================================
- Coverage 63.82% 63.7% -0.12%
==========================================
Files 102 102
Lines 9459 9459
==========================================
- Hits 6037 6026 -11
- Misses 2862 2868 +6
- Partials 560 565 +5
|
Contributor
|
please rebase against latest develop |
melekes
approved these changes
Apr 11, 2018
melekes
approved these changes
Apr 11, 2018
Contributor
Author
|
I don't have access to merge this. |
melekes
reviewed
Apr 11, 2018
| ### Local testnet using docker | ||
|
|
||
| # Build linux binary on other platforms | ||
| build-linux: |
Contributor
There was a problem hiding this comment.
can you add these commands to .PHONY
Contributor
Author
There was a problem hiding this comment.
yes, good catch!
firelizzard18
pushed a commit
to AccumulateNetwork/tendermint
that referenced
this pull request
Feb 1, 2024
…tendermint#1450) Bumps [styfle/cancel-workflow-action](https://github.com/styfle/cancel-workflow-action) from 0.11.0 to 0.12.0. - [Release notes](https://github.com/styfle/cancel-workflow-action/releases) - [Commits](styfle/cancel-workflow-action@0.11.0...0.12.0) --- updated-dependencies: - dependency-name: styfle/cancel-workflow-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.