p2p: require all addresses come with an ID no matter what#1352
Merged
p2p: require all addresses come with an ID no matter what#1352
Conversation
291dd0c to
ee3e40d
Compare
Contributor
ee3e40d to
2f87965
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1352 +/- ##
===========================================
+ Coverage 61.66% 61.79% +0.13%
===========================================
Files 114 114
Lines 11012 10993 -19
===========================================
+ Hits 6790 6793 +3
+ Misses 3574 3564 -10
+ Partials 648 636 -12
|
odeke-em
reviewed
Mar 23, 2018
| // NewNetAddressStringWithIDRequired returns a new NetAddress using the provided | ||
| // address in the form of "ID@IP:Port". | ||
| // Also resolves the host if host is not an IP. | ||
| func NewNetAddressString(addr string) (*NetAddress, error) { |
Contributor
There was a problem hiding this comment.
Did you forget to change the name or should that name doc be reverted to NewNetAddressString from NewNetAddressStringWithIDRequired?
odeke-em
reviewed
Mar 23, 2018
| idBytes, err := hex.DecodeString(idStr) | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, fmt.Sprintf("Address (%s) contains invalid ID", addr)) | ||
| return nil, errors.Wrapf(err, "Address (%s) contains invalid ID", addrWithoutProtocol) |
Contributor
Contributor
Author
There was a problem hiding this comment.
new lib is almost ready tendermint/tmlibs#180. but let's not wait here please
Contributor
There was a problem hiding this comment.
Cool cool, that was fast with how that new errors package was started and it is almost complete.
odeke-em
reviewed
Mar 23, 2018
|
|
||
| func TestNewNetAddressStrings(t *testing.T) { | ||
| addrs, errs := NewNetAddressStrings([]string{"127.0.0.1:8080", "127.0.0.2:8080"}) | ||
| addrs, errs := NewNetAddressStrings([]string{ |
Contributor
There was a problem hiding this comment.
Could we also test some invalid addresses? The current test just confirms the always expected case.
odeke-em
approved these changes
Mar 24, 2018
p2p/netaddress.go
Outdated
| return NewNetAddressStringWithOptionalID(addr) | ||
| } | ||
|
|
||
| // NewNetAddressStringWithIDRequired returns a new NetAddress using the provided |
Contributor
There was a problem hiding this comment.
Minor nit, the name in the doc doesn't match the actual function name:
- NewNetAddressStringWithIDRequired
- NewNetAddressStringWithOptionalID
ebuchman
approved these changes
Apr 5, 2018
firelizzard18
pushed a commit
to AccumulateNetwork/tendermint
that referenced
this pull request
Feb 1, 2024
…rmint#1352) Signed-off-by: Thane Thomson <connect@thanethomson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1228