cmd/tendermint/commands/lite: add tcp scheme to address URLs#1297
Merged
cmd/tendermint/commands/lite: add tcp scheme to address URLs#1297
Conversation
Noticed while investigating #970 As reported by @zramsay, we'd get the warning from tendermint/rpc/lib because we were passing in scheme-less addresses, so by default use "tcp". Also by default, "node" (nodeAddr) has been set to: "tcp://localhost:46657" instead of the bare: "localhost:46657" This change is just to clean up such warnings as they spuriously would spook users for a package "lite" that claims to be secure.
Codecov Report
@@ Coverage Diff @@
## develop #1297 +/- ##
==========================================
Coverage ? 60.28%
==========================================
Files ? 112
Lines ? 10880
Branches ? 0
==========================================
Hits ? 6559
Misses ? 3675
Partials ? 646
|
melekes
approved these changes
Mar 11, 2018
Contributor
Author
|
Thank you @melekes for the review and merge! |
firelizzard18
pushed a commit
to AccumulateNetwork/tendermint
that referenced
this pull request
Feb 1, 2024
* Check if genesis file is persisted in the DB and delete it. This should only happen when a node upgrades to a version of CometBFT that does not persist the genesis file. * Removed check for whether key exist, just call delete * Apply typo fix Co-authored-by: Andy Nogueira <me@andynogueira.dev> * Added changelog * Moved log message up front * Apply suggestions from code review Co-authored-by: Sergio Mena <sergio@informal.systems> --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: Sergio Mena <sergio@informal.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while investigating
#970
As reported by @zramsay, we'd get the warning
from tendermint/rpc/lib because we were passing in
scheme-less addresses, so by default use "tcp".
Also by default, "node" (nodeAddr) has been set to:
"tcp://localhost:46657"
instead of the bare:
"localhost:46657"
This change is just to clean up such warnings as
they spuriously would spook users for a package "lite"
that claims to be secure.