Conversation
bad dev experience
zramsay
approved these changes
Mar 9, 2018
xla
approved these changes
Mar 9, 2018
Codecov Report
@@ Coverage Diff @@
## develop #1293 +/- ##
===========================================
+ Coverage 60.41% 60.55% +0.13%
===========================================
Files 112 112
Lines 10863 10863
===========================================
+ Hits 6563 6578 +15
+ Misses 3656 3644 -12
+ Partials 644 641 -3
|
firelizzard18
pushed a commit
to AccumulateNetwork/tendermint
that referenced
this pull request
Feb 1, 2024
…emarshalled JSON (tendermint#1293) * node: verify genesis doc hash against the file Marshalling the doc data back into JSON to checksum is wasteful. In the future, the hash of the genesis file may be passed as a CLI or config parameter to help control coordinated upgrades. We want that hash to be the same as the hash stored in the database. * node: centralize genesis doc hash verification Don't put the requirement to verify the JSON content checksum onto every genesis doc provider, do it in one place in the main code. * node: link the issue on the recent FIXME comment * Changelog entry for tendermint#1293
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1291