privVal: Integrate socket client#1237
Merged
ebuchman merged 1 commit intofeature/priv_valfrom Feb 28, 2018
Merged
Conversation
285cef7 to
df927f5
Compare
Codecov Report
@@ Coverage Diff @@
## feature/priv_val #1237 +/- ##
====================================================
- Coverage 59.54% 59.42% -0.13%
====================================================
Files 126 126
Lines 11517 11524 +7
====================================================
- Hits 6858 6848 -10
- Misses 4006 4023 +17
Partials 653 653 |
Following ADDR 008 the node will connect to an external process to handle signing requests. Operation of the external process is left to the user. * introduce alias for PrivValidator interface on socket client * integrate socket client in node * structure tests * remove unnecessary flag
df927f5 to
74d3f7e
Compare
melekes
reviewed
Feb 23, 2018
| connDeadlineSeconds = 3 | ||
| dialRetryIntervalSeconds = 1 | ||
| dialRetryMax = 10 | ||
| defaultConnDeadlineSeconds = 3 |
Contributor
There was a problem hiding this comment.
what's the purpose of default prefix if you can't change it?
Contributor
Author
There was a problem hiding this comment.
It is possible to overwrite the timeout for the client. Usually the default prefix is used for constants.
ebuchman
approved these changes
Feb 28, 2018
cboh4
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Apr 7, 2025
…ndermint#1237) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.25.1 to 1.26.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.25.1...v1.26.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following ADDR 008 the node will connect to an external process to handle signing requests. Operation of the external process is left to the user.
Follow-up to #1204 against #1203.