Conversation
Closed
Contributor
Author
|
crypto byte arrays (pubkey, priv key, sig for ed25519) are all fixed length now (so we can call ReadFull on exactly the right sized read buffer in shareAuthSigs) |
binary/reflect.go
Outdated
Contributor
Author
There was a problem hiding this comment.
I didn't like it. But with the old code it seemed to be hex encoding the call to eg pubKey.String()
Contributor
Author
There was a problem hiding this comment.
do you have a better way to do this?
ebuchman
added a commit
that referenced
this pull request
Jun 20, 2018
Fix #112 by using RWMutex per element
liamsi
pushed a commit
to liamsi/tendermint
that referenced
this pull request
Jun 21, 2018
Release/v0.7.0
faddat
pushed a commit
to faddat/tendermint
that referenced
this pull request
Nov 23, 2022
BadgerDB is pretty heavy, let's not include it by default. Related to tendermint#113.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chunkLengthwould crash the nodeshareAuthSignatureUnfortunately, I couldn't think of an easy way to implement tests for my fixes (I tested both manually).