Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1076 +/- ##
==========================================
Coverage ? 59.94%
==========================================
Files ? 116
Lines ? 10748
Branches ? 0
==========================================
Hits ? 6443
Misses ? 3724
Partials ? 581 |
melekes
approved these changes
Jan 7, 2018
| The node operates in seed mode. It will kick incoming peers after sharing some peers. | ||
| It will continually crawl the network for peers. | ||
| The node operates in seed mode. In seed mode, a node continuously crawls the network for peers, | ||
| and upon incoming connection shares some peers and disconnect. |
| RemoteAddr string | ||
| ListenAddr string | ||
| Version string | ||
| Channels []int8 |
Contributor
There was a problem hiding this comment.
something wrong with formatting
odeke-em
reviewed
Jan 8, 2018
| When we haven't received any messages on an `MConnection` in a time `pingTimeout`, we send a ping message. | ||
| When a ping is received on the `MConnection`, a pong is sent in response. | ||
| When a ping is received on the `MConnection`, a pong is sent in response only if there are no other messages | ||
| to send and the peer has not sent us too many pings. |
Contributor
There was a problem hiding this comment.
How many are too many pings?
Contributor
There was a problem hiding this comment.
// TODO: prevent abuse, as they cause flush()'s.
c.Logger.Debug("Receive Ping")
c.pong <- struct{}{}
it's a TODO I believe
melekes
approved these changes
Jan 8, 2018
zramsay
pushed a commit
that referenced
this pull request
Jan 10, 2018
ebuchman
added a commit
that referenced
this pull request
Jan 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from #1057