Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1069 +/- ##
===========================================
+ Coverage 59.94% 59.96% +0.01%
===========================================
Files 116 116
Lines 10748 10748
===========================================
+ Hits 6443 6445 +2
Misses 3724 3724
+ Partials 581 579 -2 |
docs/examples/getting-started.md
Outdated
|
|
||
| ## Overview | ||
|
|
||
| Tendermint is ... |
There was a problem hiding this comment.
do we need this section in getting started?
There was a problem hiding this comment.
it's meant to be a one-liner filled in last. It's probably not needed but it's what was asked for
docs/examples/getting-started.md
Outdated
|
|
||
| ## Install | ||
|
|
||
| Note: Quick Start on a fresh machine can be done with [this script](https://gist.githubusercontent.com/zramsay/4bca8907a97ad825c30cfdc6f72ba97b/raw/b94bf36e34181a2960f9fe0d3eff260d03b6064e/install_tendermint.sh); tested on Ubuntu 16.04. It is used in the cluster deployment below. |
There was a problem hiding this comment.
let's add a command to run
curl -L https://gist.githubusercontent.com/zramsay/4bca8907a97ad825c30cfdc6f72ba97b/raw/b94bf36e34181a2960f9fe0d3eff260d03b6064e/install_tendermint.sh | bash
or
curl -L https://git.io/vNTiV | bash
There was a problem hiding this comment.
Note: this link will change to refer to the file currently being check-in with this PR, however, that file should point to master branch, so that can wait until release
docs/examples/getting-started.md
Outdated
| - `go` minimum version 1.9.2 | ||
| - `$GOPATH` set and `$GOPATH/bin` on your $PATH (see https://github.com/tendermint/tendermint/wiki/Setting-GOPATH) | ||
|
|
||
| To create the `tendermint` binary, run: |
There was a problem hiding this comment.
To install Tendermint, run ?
docs/examples/getting-started.md
Outdated
| Then, `ssh` into each machine, and `curl` then execute [this script](https://gist.githubusercontent.com/zramsay/4bca8907a97ad825c30cfdc6f72ba97b/raw/b94bf36e34181a2960f9fe0d3eff260d03b6064e/install_tendermint.sh): | ||
|
|
||
| ``` | ||
| curl -o tmint.sh https://gist.githubusercontent.com/zramsay/4bca8907a97ad825c30cfdc6f72ba97b/raw/b94bf36e34181a2960f9fe0d3eff260d03b6064e/install_tendermint.sh |
There was a problem hiding this comment.
curl -L https://git.io/vNTiV | bash
| #!/usr/bin/env bash | ||
|
|
||
| # get and unpack golang | ||
| curl -O https://storage.googleapis.com/golang/go1.9.2.linux-amd64.tar.gz |
There was a problem hiding this comment.
this will not work for x86 and macOS... maybe we need an if OS == darwin
There was a problem hiding this comment.
i know, that's explicit in this line https://github.com/tendermint/tendermint/pull/1069/files#diff-efa5271fdabd2250b8d2dd60cfc5ff1dR9
This script is meant explicitly for a Ubuntu on a DO box. I'll make it clearer in the script itself
| echo "export PATH=\$PATH:/usr/local/go/bin" >> ~/.profile | ||
|
|
||
| ## create the GOPATH directory, set GOPATH and put on PATH | ||
| mkdir goApps |
There was a problem hiding this comment.
is this from official guides?
There was a problem hiding this comment.
the official guide doesn't even set a $GOPATH, so no. AFAICT there is no standard for naming this directory (I've seen work, gocode, go, goApps etc, the list goes on)
| curl -O https://storage.googleapis.com/golang/go1.9.2.linux-amd64.tar.gz | ||
| tar -xvf go1.9.2.linux-amd64.tar.gz | ||
|
|
||
| apt install make |
There was a problem hiding this comment.
what if no apt? what about yum?
There was a problem hiding this comment.
see previous comment. it's not meant a multi-OS check-all-the-things scripts, but rather as a quick and dirty get-started-ASAP-on-Digital-OCean
| cd $GOPATH/src/$REPO | ||
|
|
||
| ## build | ||
| git checkout v0.15.0 |
There was a problem hiding this comment.
maybe we need to check for git as well or install it above (apt-get install make git)
There was a problem hiding this comment.
git is already instaled on Ubnutn 16.04
|
|
||
| This will install `go` and other dependencies, get the Tendermint source code, then compile the `tendermint` binary. | ||
|
|
||
| Next, `cd` into `docs/examples`. Each command below should be run from each node, in sequence: |
There was a problem hiding this comment.
Can't we just run tendermint node --home ./nodeN --proxy_app=dummy --p2p.seeds IP1:46656,IP2:46656,IP3:46656,IP4:46656 on each node?
There was a problem hiding this comment.
sure but that's more text, and will lead to more Error can't connect to peer than otherwise
…dermint#1069) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.7.0 to 2.8.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2.7.0...v2.8.0) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.