This repository was archived by the owner on Feb 23, 2022. It is now read-only.
document state sync ABCI interface and P2P protocol#90
Merged
tessr merged 7 commits intotendermint:masterfrom May 5, 2020
erikgrinaker:erik/statesync
Merged
document state sync ABCI interface and P2P protocol#90tessr merged 7 commits intotendermint:masterfrom erikgrinaker:erik/statesync
tessr merged 7 commits intotendermint:masterfrom
erikgrinaker:erik/statesync
Conversation
melekes
reviewed
Apr 28, 2020
melekes
approved these changes
Apr 28, 2020
Contributor
alexanderbez
left a comment
There was a problem hiding this comment.
Excellent! The documented changes were very easy to follow. I left a few minor questions 👍
13 tasks
tessr
added a commit
that referenced
this pull request
May 5, 2020
melekes
pushed a commit
that referenced
this pull request
May 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The corresponding Tendermint PRs are tendermint/tendermint#4704 and tendermint/tendermint#4705.
We should probably add a guide that reads more like a hands-on tutorial as well, with actual commands and examples. I'll write this as part of the release package.