This repository was archived by the owner on Jul 15, 2018. It is now read-only.
Error string instead of codespacing, list of lists of tags#279
Closed
Error string instead of codespacing, list of lists of tags#279
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #279 +/- ##
===========================================
- Coverage 10.12% 10.09% -0.04%
===========================================
Files 13 13
Lines 2252 2269 +17
===========================================
+ Hits 228 229 +1
- Misses 2006 2022 +16
Partials 18 18
Continue to review full report at Codecov.
|
Contributor
Author
|
Ready for review. Would be cool if this could be merged before ABCI is moved into Tendermint. |
cwgoes
added a commit
to tendermint/tendermint
that referenced
this pull request
Jun 23, 2018
Closed
4 tasks
Contributor
Author
|
Closing in favor of tendermint/tendermint#1803. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #273
Closes #272
Will also include an ADR but want to update downstream first. Also, maybe the ADR should go in Tendermint since ABCI is being moved there?