Conversation
SuperFluffy
reviewed
Oct 13, 2025
SuperFluffy
reviewed
Oct 13, 2025
| // reth vs the consensus engine. | ||
| let mut timestamp = context.current().epoch().as_secs(); | ||
| if timestamp <= parent.timestamp() { | ||
| timestamp = parent.timestamp().saturating_add(1); |
Contributor
There was a problem hiding this comment.
This is now entirely removed - will that be a problem since now timestamp = parent.timestamp in some cases? You mentioned on slack that nothing is yet being done with the millisecond part. So I wonder if this would kill payload builds?
Member
Author
There was a problem hiding this comment.
It should be fine, we've relaxed the check in #139
SuperFluffy
approved these changes
Oct 13, 2025
Contributor
SuperFluffy
left a comment
There was a problem hiding this comment.
Approval for the consensus bits.
crates/primitives/src/header.rs
Outdated
| impl TempoHeader { | ||
| /// Returns the timestamp in milliseconds. | ||
| pub fn timestamp_millis(&self) -> u64 { | ||
| self.inner.timestamp() * 1000 + self.timestamp_millis_part |
Contributor
There was a problem hiding this comment.
Should this be saturating ops?
And provide unit tests?
unbalancedparentheses
pushed a commit
to unbalancedparentheses/tempo
that referenced
this pull request
Feb 23, 2026
Adds `timestamp_millis_part` field to `TempoHeader` defining milliseconds portion of the timestamp. For now it is not propagated to EVM as this would require some more upstream changes alike to alloy-rs/evm#193
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
timestamp_millis_partfield toTempoHeaderdefining milliseconds portion of the timestamp.For now it is not propagated to EVM as this would require some more upstream changes alike to alloy-rs/evm#193