Remove test builders from pipelinerun cancel_test.go#3260
Merged
tekton-robot merged 1 commit intotektoncd:masterfrom Sep 21, 2020
Merged
Remove test builders from pipelinerun cancel_test.go#3260tekton-robot merged 1 commit intotektoncd:masterfrom
tekton-robot merged 1 commit intotektoncd:masterfrom
Conversation
Contributor
|
/lgtm |
f5bd778 to
0d34cf9
Compare
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/retest |
sahilleth
added a commit
to sahilleth/pipeline
that referenced
this pull request
Mar 31, 2026
This commit addresses the security audit requirements from issue tektoncd#3260: 1. Add persist-credentials: false to all actions/checkout steps (artipacked audit) 2. Fix template injection by replacing ${{ }} in run blocks with env variables (template-injection audit) 3. Move permission scoping from workflow level to job level (excessive-permissions audit) 4. Add zizmor CI workflow (.github/workflows/zizmor.yaml) that runs on pushes to main and PRs Changes include: - 16 GitHub Actions workflow files updated with security hardening - 1 new zizmor CI workflow added for automated security scanning - All checkout steps now use persist-credentials: false - All template expressions moved to environment variables for safe usage - All permissions explicitly scoped at job level with minimal required access This follows the same work done in tektoncd#9667
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/area testing
/kind cleanup
#3178
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes