Skip to content

Conversation

@chmouel
Copy link
Member

@chmouel chmouel commented Jun 11, 2025

  • Changed Pending status color from blue to yellow for better clarity
  • Added explicit handling for PipelineRunPending status to display as Pending
  • Updated tests to cover PipelineRunPending condition

Before:

image

After:

image

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

- Changed Pending status color from blue to yellow for better clarity
- Added explicit handling for PipelineRunPending status to display as
  Pending
- Updated tests to cover PipelineRunPending condition
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 11, 2025
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 11, 2025
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 11, 2025
@tekton-robot tekton-robot merged commit bef67c7 into tektoncd:main Jun 11, 2025
8 checks passed
@chmouel chmouel deleted the make-pending-pending-really-pending branch June 11, 2025 14:27
vinamra28 added a commit that referenced this pull request Jul 14, 2025
#2548 | [dependabot[bot]] Bump the go-docker-dependencies group with 2 updates | 2025/05/30-06:18
#2544 | [vinamra28] Update CLI docs for tkn v0.41.0 | 2025/05/30-07:58
#2525 | [Abhishek Ghosh] Add flag to prefix log lines with log source (task and step name) by default | 2025/06/05-16:57
#2525 | [Abhishek Ghosh] updated the docs | 2025/06/05-16:57
#2525 | [Abhishek Ghosh] Add unit test scripts | 2025/06/05-16:57
#2525 | [Abhishek Ghosh] Adjust pipeline logs test to align with updated output format | 2025/06/05-16:57
#2549 | [dependabot[bot]] Bump the go-docker-dependencies group with 2 updates | 2025/06/10-10:07
#2553 | [Chmouel Boudjnah] fix: update Pending color of PipelineRunPending | 2025/06/11-14:51
#2552 | [dependabot[bot]] Bump github.com/cloudflare/circl from 1.3.7 to 1.6.1 | 2025/06/13-06:33
#2556 | [divyansh42] Fix deadlock issue when following logs | 2025/06/23-17:15
null | [dependabot[bot]] Bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.3.0 in /tools | 2025/06/30-07:27

Signed-off-by: vinamra28 <vinjain@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants