Skip to content

Conversation

@divyansh42
Copy link
Member

@divyansh42 divyansh42 commented Feb 17, 2025

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 17, 2025
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 17, 2025
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 17, 2025
@divyansh42
Copy link
Member Author

/release-note-none

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 17, 2025
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2025
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 17, 2025
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 17, 2025
Signed-off-by: divyansh42 <diagrawa@redhat.com>
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 17, 2025
@divyansh42
Copy link
Member Author

/retest

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2025
@tekton-robot tekton-robot merged commit 840577c into tektoncd:main Feb 17, 2025
8 checks passed
piyush-garg added a commit that referenced this pull request Feb 26, 2025
#2488 | [dependabot[bot]] Bump gotest.tools/v3 from 3.5.1 to 3.5.2 | 2025/02/10-14:54
#2490 | [dependabot[bot]] Bump github.com/tektoncd/chains from 0.23.1 to 0.24.0 | 2025/02/13-15:16
#2492 | [dependabot[bot]] Bump github.com/golangci/golangci-lint from 1.63.4 to 1.64.4 in /tools | 2025/02/14-11:08
#2495 | [dependabot[bot]] Bump github.com/golangci/golangci-lint from 1.64.4 to 1.64.5 in /tools | 2025/02/15-17:32
#2493 | [dependabot[bot]] Bump the go-k8s-dependencies group with 4 updates | 2025/02/15-18:22
#2496 | [divyansh42] Use go v1.23.4 and bump goreleaser to v2.5.0 | 2025/02/17-18:38
#2497 | [dependabot[bot]] Bump github.com/spf13/cobra from 1.8.1 to 1.9.1 | 2025/02/18-09:10
#2500 | [dependabot[bot]] Bump github.com/sigstore/cosign/v2 from 2.4.2 to 2.4.3 | 2025/02/20-10:10
#2499 | [dependabot[bot]] Bump the go-docker-dependencies group with 2 updates | 2025/02/20-10:42
#2502 | [dependabot[bot]] Bump github.com/google/go-cmp from 0.6.0 to 0.7.0 | 2025/02/23-18:40
null | [dependabot[bot]] Bump github.com/go-jose/go-jose/v4 from 4.0.4 to 4.0.5 | 2025/02/26-03:17

Signed-off-by: Piyush Garg <pgarg@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants