Initial knctl task definition 🌮#34
Conversation
|
/test pull-tekton-catalog-integration-tests |
|
/assign ImJasonH |
|
@dlorenc indeed 👼 I did that task for a talk at Red Hat Summit, thought I would share 😉 |
|
|
||
| This Task deploys (or update) a Knative service. It uses | ||
| [`knctl`](https://github.com/cppforlife/knctl) for that, and supports | ||
| only the `deploy` subcommand as of today. |
There was a problem hiding this comment.
https://github.com/knative/client/blob/master/docs/cmd/kn_service_create.md
The official knative client support the service creation by image as well: kn service create NAME --image IMAGE [flags].
There was a problem hiding this comment.
Yes, as written in #36 the end-goal is to use kn instead of knctl. This is merely the initial proposition. I went for knctl deploy here, as it allowed me to re-execute this same task any number of time (and it would update the service) — I wasn't sure how to do that with kn at that time 👼
There was a problem hiding this comment.
NP. I am checking whether I can make the docker image available for kn. We are good for this PR.
Adds a `knctl-deploy` task that will deploy an image (resource) as a Knative service. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
|
/lgtm |
|
@houshengbo: changing LGTM is restricted to assignees, and only tektoncd/catalog repo collaborators may be assigned issues. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vdemeester I just joined the community. Do you know what permissions I have to PRs? |
|
@houshengbo yeah, you need to be on the GitHub organization to be able to |
|
@vdemeester Could you add me into the organization? I mean how I can join as a collaborator. |
|
/lgtm |
Changes
Adds a
knctl-deploytask that will deploy an image (resource) as aKnative service.
Enhancements:
knctltask that would take any arguments as input (TaskSpec Params needs an Array type pipeline#207 is required for that or a wrapper like the one inopenshift-clienttask)knctl deploy --helphas quite some 👼)knative/clientinstead (or in addition to)Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.