Skip to content

TaskSpec Params needs an Array type #207

@tanner-bruce

Description

@tanner-bruce

In https://github.com/knative/build-pipeline/blob/8a2b6c30efa7f4dd1fedafacc2733a0d290e12c6/examples/deploy_tasks.yaml#L21, the Input Param helmArgs is used. If one were to set helmArgs to be --set arg1=a --set arg2=b with the intention of providing multiple arguments to helm, this task would fail due to --set arg1=a --set arg2=b being interpreted as a single argument.

A couple questions that comes to mind:

  1. How do we make it obvious that '${helmArgs}' could possibly be expanded to multiple arguments, while also allowing it to have a single argument? The spread operator may be a nice fit: ${helmArgs...}

2.How should a TaskParam represent an array? Currently it just has a name field, but description and default will be added soon. How does it look supporting defaults for an array alongside a regular string?

Metadata

Metadata

Assignees

Labels

designThis task is about creating and discussing a designhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.meaty-juicy-coding-workThis task is mostly about implementation!!! And docs and tests of course but that's a given

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions