@happz In the issue, you mention the following:

With container plugin, options are worthless and may lead to incorrect or unexpected behavior.

and

tmt shall set archive=True or preserve_permissions=True rather than 1. adding "-p" that rsync would consume and 2. relying on podman cp --archive being enabled by default.

If I understand it correctly, should I also add --archive option to this command based on the TransferOptions passed into the function? If yes, would it make sense to log a warning if some options are provided that will have no effect?

@happz In the issue, you mention the following:

With container plugin, options are worthless and may lead to incorrect or unexpected behavior.

and

tmt shall set archive=True or preserve_permissions=True rather than 1. adding "-p" that rsync would consume and 2. relying on podman cp --archive being enabled by default.

If I understand it correctly, should I also add --archive option to this command based on the TransferOptions passed into the function?

I believe so, yes, that's how it should work. Plugin-agnostic options, each plugin translating them into their own domain.

If yes, would it make sense to log a warning if some options are provided that will have no effect?

Probably, but it's tricky: if a plugin does not support e.g. chmod, and pushed files always get ugo=rwx permissions, the plugin should run extra chmod to "fix" the permissions so they reflect the given options. Not necessarily in this PR, container is ignoring them for some time already, no rush, but I think it's what should happen eventually.

On the other hand, some options may be impossible to support, then a warning would be a good start, but eventually we should resolve that too: a caller sets an options because it tries to reach some state on the guest, e.g. executable test script. The plugin cannot deliver that, ever, it has no way to set executable bits, it's really limited. We need to fix that somehow, otherwise the caller would expect something that wouldn't be true, possibly causing seemingly unrelated issues elsewhere.

Added missing exclude in 92db5df.