Encode special characters as HTML entities #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I took a quick glance, and this looks good to me. Is it necessary to encode this many of the entities? I suppose better safe than sorry.... I'll take another look in the morning when I'm not so tired. |
Owner
|
I'm merging this. Thank you very much! |
technosophos
added a commit
that referenced
this pull request
Dec 31, 2015
Encode special characters as HTML entities
Contributor
Author
|
I don't know if all of them are needed, probably depends on the exact use case. The list of entities I used actually comes from Python's htmlentitydefs module: https://docs.python.org/2.7/library/htmllib.html#module-htmlentitydefs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encodes special characters as html entities, a common issue is
in the original source shows up as À in Dash.Note: I'm new to Go so I may have implemented this in the worst way possible, therefore I'm open to all criticism. (-: